> -----Original Message-----
> From: Gerhard Sittig [mailto:g...@denx.de]
> Sent: Wednesday, January 15, 2014 5:18 PM
> To: Piotr Wilczek
> Cc: u-boot@lists.denx.de; Kyungmin Park
> Subject: Re: [U-Boot] [PATCH 3/7] board:samsung:common: set envs with
> board unified information
>
> On Tue, Jan 14, 2014 at 08:59 +0100, Piotr Wilczek wrote:
> >
> > This patch enables to set envs that describe board information.
> > The following envs are set (but not saved): soc_id, soc_rev,
> board_rev.
>
> I don't see the "not saved" part in the patch. How exactly does a
> "saveenv" not save those programmatically generated variables?
> (Altera SoCFPGA suffers from the same issue, we may not want to repeat
> this in mainline U-Boot)
>
It means only that I don't save the generated variables to persistent
storage.
I will modify the commit message to be more specific.
> > Based on this information, 'fdtaddr' env is set (not saved) as:
> > fdtaddr=${soc_family}${soc_id}-${board}.dtb
>
> An address variable resolves to a DTB filename? That would be
> unexpected. Or is it a typo in the commit message?
It's a typo, I will fix the commit message.
>
>
> virtually yours
> Gerhard Sittig
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de
Best regards,
Piotr Wilczek
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
