> -----Original Message----- > From: York Sun [mailto:york...@freescale.com] > Sent: Saturday, December 07, 2013 12:39 AM > To: Liu Shengzhou-B36685; u-boot@lists.denx.de > Subject: Re: [PATCH] t2080qds/ddr: update ddr parameters > > On 12/06/2013 12:53 AM, Shengzhou Liu wrote: > > - optimize ddr parameters for whole frequency range from 1500MT/s to > 2140MT/s. > > - remove unused patameters: 'cpo', 'wrdata delay', '2T', which is > unrelated > > to DDR3/3L on t2080qds. > > - remove unused rdimm code(only udimm is supported on t2080qds). > > > > Signed-off-by: Shengzhou Liu <shengzhou....@freescale.com> > > --- > > Against master branch of git://git.denx.de/u-boot-mpc85xx.git > > > > board/freescale/t2080qds/ddr.c | 20 ++----------- > > board/freescale/t2080qds/ddr.h | 64 > > +++++++++--------------------------------- > > 2 files changed, 17 insertions(+), 67 deletions(-) > > > > diff --git a/board/freescale/t2080qds/ddr.c > > b/board/freescale/t2080qds/ddr.c index 5db5d21..bc366ae 100644 > > --- a/board/freescale/t2080qds/ddr.c > > +++ b/board/freescale/t2080qds/ddr.c > > @@ -24,24 +24,17 @@ void fsl_ddr_board_options(memctl_options_t *popts, > > const struct board_specific_parameters *pbsp, *pbsp_highest = NULL; > > ulong ddr_freq; > > > > - if (ctrl_num > 2) { > > + if (ctrl_num > 1) { > > printf("Not supported controller number %d\n", ctrl_num); > > return; > > } > > if (!pdimm->n_ranks) > > return; > > > > - /* > > - * we use identical timing for all slots. If needed, change the > code > > - * to pbsp = rdimms[ctrl_num] or pbsp = udimms[ctrl_num]; > > - */ > > - if (popts->registered_dimm_en) > > - pbsp = rdimms[0]; > > - else > > - pbsp = udimms[0]; > > + pbsp = udimms[0]; > > > > This is not right. You should throw out an error if RDIMM is not supported. [Shengzhou] okay. > But why isn't it supported? T2080 SoC can support RDIMM. [Shengzhou] T2080 SoC can support uDIMM and rDIMM, but T2080QDS board supports only UDIMM according to T2080QDS RM.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
