Hello Tom, Simon.
> On Mon, Nov 11, 2013 at 12:47:53PM +0900, Masahiro Yamada wrote: > > > Commit fea25720 renamed arch/i386 to arch/x86. > > But it missed to modify examples/standalone/Makefile. > > > > This commit revives examples/standalone/82559_eeprom. > > > > Signed-off-by: Masahiro Yamada <yamad...@jp.panasonic.com> > > Cc: Simon Glass <s...@chromium.org> > > > > --- > > Hello, Simon. > > > > I think examples/standalone/82559_eeprom should have been > > originally implemented for i386(x86) architecture > > but it has never compiled more than two years. > > (And I am probably the first one to notice this.) > > > > I chosed to add it again rather than delete it in this patch. > > If you do not need it any more, I am glad to re-post v2 > > to delete it. > > Note that now that we build this I see: > i586-angstrom-linux-ld: warning: cannot find entry symbol 82559_eeprom; > defaulting to 0000000000040000 > > So a new warning on coreboot-x86. I'm giving this patch to Simon in > patchwork and he can either follow-up with a patch fixing the warning or > nak and delete the example. > > -- > Tom Simon. I am not sure if examples/standalone/8259_eeprom.c is necessary or not because I could not get any comments from you about this patch. But it's OK for now. Anyway I want to go forward. So, I posted a new patch to replace this patch: http://patchwork.ozlabs.org/patch/294742/ In that patch, I commened out 82559_eeprom in Makefile. Please note a TODO item in a comment block in examples/standalone/Makefile: # TODO: # - Fix the warning of 82559_eeprom.c and uncomment the following # or # - Delete 82559_eeprom.c and the following line #ELF-$(CONFIG_X86) += 82559_eeprom You don't need to hurry to do this. But I'd appreciate if you could do this when you find time. Tom. I do not need this patch any more. Could you change the status of this patch to Superseded? Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
