Hi Giuseppe, On 15/11/2013 17:42, Giuseppe Pagano wrote: > Add Ethernet and networking support on uDoo board (FEC +phy Micrel KSZ9031). > Ethernet speed is currently limited to 10/100Mbps. > > Signed-off-by: Giuseppe Pagano <giuseppe.pag...@seco.com> > Tested-by: Fabio Estevam <fabio.este...@freescale.com> > CC: Stefano Babic <sba...@denx.de> > CC: Fabio Estevam <fabio.este...@freescale.com> > ---
IMHO the patch is ok. If there are not any further comments, I mark your patchset for merging. > + ksz9031_phy_extended_write(phydev, 0x02, > + MII_KSZ9031_EXT_RGMII_CLOCK_SKEW, > + MII_KSZ9031_MOD_DATA_NO_POST_INC, 0x03FF); I had also some issues with KSZ9031 and i.MX6. Gigabit starts working only after setting the clock skew. I see you set the register again with the default value (0x3FF). Because it is the reset value, it is not required to set it again, but more important : have you make a trying enabling Gb and adjusting only this extended register ? Rather the KSZ9031's manual is not clear and does not say a lot about it, Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
