On Mon, 28 Oct 2013 16:00:06 -0600 Stephen Warren <swar...@wwwdotorg.org> wrote:
> On 10/21/2013 08:28 AM, Alban Bedel wrote: > > Add support for the new Tamonten™ NG platform from Avionic Design. > > Currently only I2C, MMC, USB and ethernet have been tested. > > What changed in v3? There's no changelog here, so I don't know where to > concentrate my re-review of this patch... I'll add one. It was unclear to me how these should be done, and it took me quiet some times to find out about this 3 dashes hidden feature. > > diff --git a/board/avionic-design/common/tamonten-ng.c > > b/board/avionic-design/common/tamonten-ng.c > > > +#define MAX_I2C_RETRY 3 > > I don't think that's used any more. I'll remove it. > Most of the PMU #defines aren't used either. I'll remove them too, althought I hate having hardcoded values in the code instead of a human readable definition of the registers. > > +#ifdef CONFIG_BOARD_EARLY_INIT_F > > I don't think any of these ifdefs are required, since the config file > hard-codes all those values. Same for #if defined(CONFIG_TEGRA_MMC) > below, and perhaps more? Will do. > > +void gpio_early_init(void) > > +{ > > + /* Turn on the alive signal */ > > + gpio_request(GPIO_PV2, "ALIVE"); > > + gpio_direction_output(GPIO_PV2, 1); > > + > > + /* Remove the reset on the reset on the external periph */ > > "reset on the reset on the" ? > > > diff --git a/board/avionic-design/dts/tegra30-tamonten.dtsi > > b/board/avionic-design/dts/tegra30-tamonten.dtsi > > > + i2c@7000c000 { > > + status = "okay"; > > + clock-frequency = <100000>; > > + }; > > + > > + i2c@7000c400 { > > + status = "okay"; > > + clock-frequency = <100000>; > > + }; > ... > > Do all the carrier boards guarantee that all those I2C and SPI, and even > SDHCI busses are routed somewhere? It may be best to defer adding > status="okay" to the leaf board files, so you know there's actually > something hooked up there. Most of these are on the COM module, but you are right, a few of them shouldn't have status="okay" in this dtsi. Alban _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot