Hi, Thanks for your review.
2013/10/17 Heiko Schocher <h...@denx.de>: > Hello Nobuhiro, > > Am 17.10.2013 09:18, schrieb Nobuhiro Iwamatsu: > >> Kzm9g uses sh_i2c driver. sh_i2c driver updated to new I2C framwork. >> This updates kzm9g to this change. >> >> Signed-off-by: Nobuhiro Iwamatsu<nobuhiro.iwamatsu...@renesas.com> >> >> --- >> board/kmc/kzm9g/kzm9g.c | 2 +- >> include/configs/kzm9g.h | 31 ++++++++++++++++--------------- >> 2 files changed, 17 insertions(+), 16 deletions(-) > > > Could you sqash this patch into http://patchwork.ozlabs.org/patch/284106 > so we get no problems with "git bisect". OK, I will squash this patch and re-send. > > Beside of that only one comment: > > >> diff --git a/board/kmc/kzm9g/kzm9g.c b/board/kmc/kzm9g/kzm9g.c >> index b669ffe..0ec5e8e 100644 >> --- a/board/kmc/kzm9g/kzm9g.c >> +++ b/board/kmc/kzm9g/kzm9g.c >> @@ -289,7 +289,7 @@ void adjust_core_voltage(void) >> { >> u8 data; >> >> - i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE); >> + i2c_init(CONFIG_SYS_I2C_SH_SPEED0, CONFIG_SYS_I2C_SLAVE); > > > You no longer need to call i2c_init, as this does i2c_set_bus_num() > for you. Please remove this and test, thanks! I see. I will update this patch. > > bye, > Heiko Best regards, Nobuhiro -- Nobuhiro Iwamatsu _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
