On Thu, 2013-10-10 at 16:30 +0530, Pekon Gupta wrote:
> -#ifdef CONFIG_AM33XX
> - wr_mode = BCH_WRAPMODE_1;
> + if (bch->ecc_scheme == OMAP_ECC_BCH8_CODE_HW) {
> + wr_mode = BCH_WRAPMODE_1;
>
> switch (bch->nibbles) {
> case ECC_BCH4_NIBBLES:
> @@ -320,7 +317,7 @@ static void omap_hwecc_init_bch(struct nand_chip *chip,
> int32_t mode)
> val |= (unused_length << 22);
> break;
> }
> -#else
> + } else {
> /*
> * This ecc_size_config setting is for BCH sw library.
> *
> @@ -333,7 +330,7 @@ static void omap_hwecc_init_bch(struct nand_chip *chip,
> int32_t mode)
> * size1 = 32 (skip 32 nibbles = 16 bytes per sector in spare area)
> */
> val = (32 << 22) | (0 << 12);
> -#endif
> + }
Either indentation or braces are wrong above. If it's just the
indentation that's wrong, let me know and I can fix up when applying.
> +/**
> + * omap_select_ecc_scheme - configures driver for particular ecc-scheme
> + * @nand: NAND chip device structure
> + * @ecc_scheme: ecc scheme to configure
> + * @pagesize: number of main-area bytes per page of NAND device
> + * @oobsize: number of OOB/spare bytes per page of NAND device
> + */
> +static int omap_select_ecc_scheme(struct nand_chip *nand,
> + enum omap_ecc ecc_scheme, unsigned int pagesize, unsigned int oobsize) {
Brace goes on its own line for function definitions. Again, I can fix
this while applying.
-Scott
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
