-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/07/2013 09:06 PM, Scott Wood wrote: > On Sat, 2013-10-05 at 06:11 +0000, Gupta, Pekon wrote: >> Hi, >> Please see the replies inline.. >> >>> From: Scott Wood [mailto:scottw...@freescale.com] >>>> On Mon, 2013-09-30 at 19:43 +0530, Pekon Gupta wrote: >>>> +Platform specific options >>>> +========================= >>>> + >>>> + CONFIG_NAND_OMAP_ECCSCHEME >>>> + On OMAP platforms, this specifies NAND ECC scheme. >>>> + 1 - HAM1_SW 1-bit Hamming code using software library >>>> + (for legacy devices only) >>>> + 2 - HAM1_HW 1-bit Hamming code using GPMC hardware engine >>>> + (for legacy devices only) >>>> + 3 - BCH4_SW 4-bit BCH code (unsupported) >>>> + 4 - BCH4_HW 4-bit BCH code (unsupported) >>>> + 5 - BCH8_SW 8-bit BCH code with >>>> + - ecc calculation using GPMC hardware engine, >>>> + - error detection using software library. >>>> + - requires CONFIG_BCH to enable software BCH >>> library >>>> + (For legacy device which do not have ELM h/w >>> engine) >>>> + 6 - BCH8_HW 8-bit BCH code with >>>> + - ecc calculation using GPMC hardware engine, >>>> + - error detection using ELM hardware engine. >>> >>> You should document the symbols, not the numbers that happen to be >>> assigned to them. >>> >> Sorry din't get you. This is based on your below feedback >> http://lists.denx.de/pipermail/u-boot/2013-September/162773.html >> >> Example: "6 - BCH8_HW" means 8-bit BCH ECC scheme using h/w engine. >> It is this number is what user needs to specify in include/configs/*.h >> Any other internal symbol like "OMAP_ECC_BCH8_CODE_SW" should >> not be exposed to user, user-interface should remain constant. > > I disagree. The user should specify OMAP_ECC_BCH8_CODE_SW. It's more > greppable, and it's more likely that the number will change than that > the name will.
I agree with Scott, enum (if it's not already one) and use the name so it's clear what you're picking. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSU2cEAAoJENk4IS6UOR1WnOQP/30AInl+d0QVU6QHq+DsGC/q Wh/yfXbN/EkWVPEvpASS5gftTSd+UjLSzUSWca+TcQxUVdzD64H1u4j8An2cSwJp vQuX1QZzMWA+g6D+u75BKMs/cIXb6rwX9A5is5R/k5cU4mew+ecLmBeRLcTENfpM +ROD7XfSJsXYff+dLhpOeVWC6ELzjgmHWajoqpdZNefrMtsrRHOeLd9ccbqYxoNZ Td56vwMYfk8f+BBRmGlFRdAf+xN+9ssou1CipK6E/H0QHnexRkuPINRdmPD4/p0o yP+opvOUq8XMYiO76HOGb37tMJvjgziEcZUy4S3Q0gbhRlC9EXz1D0qxs6ti1EFs 9M/Wsl8bsKx4rgdf12hj8iebFxvTdT1lXejJGNk9ThHqsHE0pl+K1cyouZ/GL0NA sk/UCPe7DL3RIAtkUy+pLT7A3nOKIhqJY1kTsPN24qTF7UVlatWov6C33d42jDzp YH5CkdP1FRffkRj1in1ex0CiVB/3h3SuI4kA+hceWdx0rGYRT/PRKQA3qSulU1p4 lx3jtzt07fSflPdeX9PxW5k9CqAmXut4rw5USU1OAdpRKANzp1FPXcKXjEVd2uQ1 zkfgUB4MeR6xs6HE6q5xBbaaRhy9zJX415ZG10NtKUXCrVBIoif51EQQmlvehgcy ufn39bBOmsjkXYXzJI8W =tQHU -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
