On Thursday 16 April 2009, Wolfgang Denk wrote: > > So what the patch does is to remove an unused code part. Is this what you > > are complaining about? If really needed I could resend this patch with a > > modified patch subject. > > No, I complain that you also change a vital costant without even > mentioning.
The constant was not used at all (as I mentioned in my last mail). So changing it to the really used value seems logical to me. > Normally, this should be split into two separate patches., but at > least it should be stated in the commit message. I'll resend the patch with a changed commit text later. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot