Dear Piotr Wilczek, On 30/08/13 15:00, Piotr Wilczek wrote: > Dear Minkyu Kang, > >> -----Original Message----- >> From: Minkyu Kang [mailto:mk7.k...@samsung.com] >> Sent: Friday, August 30, 2013 6:39 AM >> To: Piotr Wilczek >> Cc: u-boot@lists.denx.de; Kyungmin Park; Lukasz Majewski >> Subject: Re: [PATCH V4 1/3] power:battery: add battery support for >> Trats2 board >> >> Dear Piotr Wilczek, >> >> On 29/08/13 17:49, Piotr Wilczek wrote: >>> Signed-off-by: Piotr Wilczek <p.wilc...@samsung.com> >>> Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com> >>> --- >>> drivers/power/battery/Makefile | 1 + >>> drivers/power/battery/bat_trats2.c | 65 >> ++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 66 insertions(+) >>> create mode 100644 drivers/power/battery/bat_trats2.c >>> >> >> bat_trats2.c is almost same with bat_trat.c I think, it can be reuse >> bat_trat.c Do you have special reason to add new file? > > If several boards would use that file, any change to it will affect all > these boards. Also why it should be named 'bat_trats' then?
OK. I understood what you said. But, I don't understand why this file (or directory - battery) is needed. It is not a driver, it just settings for specific board. If so, why don't you move to board file instead? Do we need to make new files for every boards? Lukasz, how you think? > > Other reason is that I don't want to block command line while charging > battery as in 'bat_trats'. > > Anyway it's not that important. I will modify it the way you prefer. > > Best regards, > Piotr Wilczek > >> >> Thanks, >> Minkyu Kang. > > > Thanks, Minkyu Kang. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
