On Tue, Aug 13, 2013 at 05:09:57PM +0100, Mark Jackson wrote: > +++ b/board/newflow/nanobone/board.c [snip] > +#if defined(CONFIG_SPL_BUILD) || (CONFIG_NOR_BOOT) > +//static struct uart_sys *uart_base = (struct uart_sys *)DEFAULT_UART_BASE; > +#endif
Here and elsewhere, remove commented out code. > +++ b/include/configs/nanobone.h [snip] > +#define CONFIG_DMA_COHERENT > +#define CONFIG_DMA_COHERENT_SIZE (1 << 20) [snip] > +#define CONFIG_STACKSIZE (128 * 1024) Unused [snip] > +#define CONFIG_CMD_FAT > +#define CONFIG_CMD_EXT2 > +#define CONFIG_CMD_EXT4 But no CONFIG_CMD_FS_GENERIC ? > + /* Physical Memory Map */ > +#define CONFIG_NR_DRAM_BANKS 1 /* 1 bank of DRAM */ > +#define PHYS_DRAM_1 0x80000000 /* DRAM Bank #1 */ > +#define CONFIG_MAX_RAM_BANK_SIZE (1024 << 20) /* 1GB */ Please just use 0x80000000 directly in later defines, or CONFIG_SYS_SDRAM_BASE in code. [snip] > +#define CONFIG_SPL_NET_VCI_STRING "AM335x U-Boot SPL" I would strongly encourage "nanobone" somewhere in this string, so that you don't feed the binary for an am335x_evm.h-based board to this board. Or drop if you aren't really supporting SPL via USB or ethernet. > +/* Unsupported features */ > +#undef CONFIG_USE_IRQ [snip] > +#define CONFIG_BOOTP_DEFAULT Unused. And I realize everything but the VCI string and lack of CONFIG_CMD_FS_GENERIC is inherited from am335x_evm.h, I'm working on a series to fix that now. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
