Dear Sourav Poddar,
In message <1374569979-28660-8-git-send-email-sourav.pod...@ti.com> you wrote:
> Qspi controller has a memory mapped port which can be used for
> data transfers. First controller need to be configured through
> configuration port, then for data read switch the controller
> to memory mapped and read from the predefined location.
>
> Signed-off-by: Sourav Poddar <sourav.pod...@ti.com>
> ---
> drivers/mtd/spi/spansion.c | 1 +
> drivers/mtd/spi/spi_flash.c | 8 +++-
> drivers/spi/ti_qspi.c | 85
> +++++++++++++++++++++++++++++++++++-------
> include/configs/dra7xx_evm.h | 3 +-
> include/spi.h | 3 +
> 5 files changed, 84 insertions(+), 16 deletions(-)
changelog missing, and an awful lot of checkpatch issues which need to
be fixed:
ERROR: code indent should use tabs where possible
#112: FILE: drivers/mtd/spi/spansion.c:154:
+ flash->memory_map = spi->memory_map;$
WARNING: please, no spaces at the start of a line
#112: FILE: drivers/mtd/spi/spansion.c:154:
+ flash->memory_map = spi->memory_map;$
ERROR: code indent should use tabs where possible
#154: FILE: drivers/spi/ti_qspi.c:26:
+ u32 cmd;$
WARNING: please, no spaces at the start of a line
#154: FILE: drivers/spi/ti_qspi.c:26:
+ u32 cmd;$
ERROR: code indent should use tabs where possible
#155: FILE: drivers/spi/ti_qspi.c:27:
+ u32 dc;$
WARNING: please, no spaces at the start of a line
#155: FILE: drivers/spi/ti_qspi.c:27:
+ u32 dc;$
ERROR: code indent should use tabs where possible
#233: FILE: drivers/spi/ti_qspi.c:237:
+ qslave->dc = 0;$
WARNING: please, no spaces at the start of a line
#233: FILE: drivers/spi/ti_qspi.c:237:
+ qslave->dc = 0;$
ERROR: code indent should use tabs where possible
#234: FILE: drivers/spi/ti_qspi.c:238:
+ if (qslave->mode & SPI_CPHA)$
WARNING: please, no spaces at the start of a line
#234: FILE: drivers/spi/ti_qspi.c:238:
+ if (qslave->mode & SPI_CPHA)$
ERROR: code indent should use tabs where possible
#235: FILE: drivers/spi/ti_qspi.c:239:
+ qslave->dc |= QSPI_CKPHA(slave->cs);$
WARNING: please, no spaces at the start of a line
#235: FILE: drivers/spi/ti_qspi.c:239:
+ qslave->dc |= QSPI_CKPHA(slave->cs);$
ERROR: code indent should use tabs where possible
#236: FILE: drivers/spi/ti_qspi.c:240:
+ if (qslave->mode & SPI_CPOL)$
WARNING: please, no spaces at the start of a line
#236: FILE: drivers/spi/ti_qspi.c:240:
+ if (qslave->mode & SPI_CPOL)$
ERROR: code indent should use tabs where possible
#237: FILE: drivers/spi/ti_qspi.c:241:
+ qslave->dc |= QSPI_CKPOL(slave->cs);$
WARNING: please, no spaces at the start of a line
#237: FILE: drivers/spi/ti_qspi.c:241:
+ qslave->dc |= QSPI_CKPOL(slave->cs);$
ERROR: code indent should use tabs where possible
#238: FILE: drivers/spi/ti_qspi.c:242:
+ if (qslave->mode & SPI_CS_HIGH)$
WARNING: please, no spaces at the start of a line
#238: FILE: drivers/spi/ti_qspi.c:242:
+ if (qslave->mode & SPI_CS_HIGH)$
ERROR: code indent should use tabs where possible
#239: FILE: drivers/spi/ti_qspi.c:243:
+ qslave->dc |= QSPI_CSPOL(slave->cs);$
WARNING: please, no spaces at the start of a line
#239: FILE: drivers/spi/ti_qspi.c:243:
+ qslave->dc |= QSPI_CSPOL(slave->cs);$
ERROR: code indent should use tabs where possible
#241: FILE: drivers/spi/ti_qspi.c:245:
+ writel(qslave->dc, &qspi->spi_dc);$
WARNING: please, no spaces at the start of a line
#241: FILE: drivers/spi/ti_qspi.c:245:
+ writel(qslave->dc, &qspi->spi_dc);$
ERROR: code indent should use tabs where possible
#243: FILE: drivers/spi/ti_qspi.c:247:
+ if (flags == SPI_XFER_MEM_MAP) {$
WARNING: please, no spaces at the start of a line
#243: FILE: drivers/spi/ti_qspi.c:247:
+ if (flags == SPI_XFER_MEM_MAP) {$
ERROR: code indent should use tabs where possible
#244: FILE: drivers/spi/ti_qspi.c:248:
+ writel(MM_SWITCH, &qspi->spi_switch);$
WARNING: please, no spaces at the start of a line
#244: FILE: drivers/spi/ti_qspi.c:248:
+ writel(MM_SWITCH, &qspi->spi_switch);$
ERROR: code indent should use tabs where possible
#245: FILE: drivers/spi/ti_qspi.c:249:
+ val = readl(CORE_CTRL_IO);$
WARNING: please, no spaces at the start of a line
#245: FILE: drivers/spi/ti_qspi.c:249:
+ val = readl(CORE_CTRL_IO);$
ERROR: code indent should use tabs where possible
#246: FILE: drivers/spi/ti_qspi.c:250:
+ val |= MEM_CS;$
WARNING: please, no spaces at the start of a line
#246: FILE: drivers/spi/ti_qspi.c:250:
+ val |= MEM_CS;$
ERROR: code indent should use tabs where possible
#247: FILE: drivers/spi/ti_qspi.c:251:
+ writel(val, CORE_CTRL_IO);$
WARNING: please, no spaces at the start of a line
#247: FILE: drivers/spi/ti_qspi.c:251:
+ writel(val, CORE_CTRL_IO);$
ERROR: code indent should use tabs where possible
#248: FILE: drivers/spi/ti_qspi.c:252:
+ return 0;$
WARNING: please, no spaces at the start of a line
#248: FILE: drivers/spi/ti_qspi.c:252:
+ return 0;$
ERROR: code indent should use tabs where possible
#249: FILE: drivers/spi/ti_qspi.c:253:
+ } else if (flags == SPI_XFER_MEM_MAP_END) {$
WARNING: please, no spaces at the start of a line
#249: FILE: drivers/spi/ti_qspi.c:253:
+ } else if (flags == SPI_XFER_MEM_MAP_END) {$
ERROR: code indent should use tabs where possible
#250: FILE: drivers/spi/ti_qspi.c:254:
+ writel(~MM_SWITCH, &qspi->spi_switch);$
WARNING: please, no spaces at the start of a line
#250: FILE: drivers/spi/ti_qspi.c:254:
+ writel(~MM_SWITCH, &qspi->spi_switch);$
ERROR: code indent should use tabs where possible
#251: FILE: drivers/spi/ti_qspi.c:255:
+ val = readl(CORE_CTRL_IO);$
WARNING: please, no spaces at the start of a line
#251: FILE: drivers/spi/ti_qspi.c:255:
+ val = readl(CORE_CTRL_IO);$
ERROR: code indent should use tabs where possible
#252: FILE: drivers/spi/ti_qspi.c:256:
+ val &= MEM_CS_UNSELECT;$
WARNING: please, no spaces at the start of a line
#252: FILE: drivers/spi/ti_qspi.c:256:
+ val &= MEM_CS_UNSELECT;$
ERROR: code indent should use tabs where possible
#253: FILE: drivers/spi/ti_qspi.c:257:
+ writel(val, CORE_CTRL_IO);$
WARNING: please, no spaces at the start of a line
#253: FILE: drivers/spi/ti_qspi.c:257:
+ writel(val, CORE_CTRL_IO);$
ERROR: code indent should use tabs where possible
#254: FILE: drivers/spi/ti_qspi.c:258:
+ return 0;$
WARNING: please, no spaces at the start of a line
#254: FILE: drivers/spi/ti_qspi.c:258:
+ return 0;$
ERROR: code indent should use tabs where possible
#255: FILE: drivers/spi/ti_qspi.c:259:
+ }$
WARNING: please, no spaces at the start of a line
#255: FILE: drivers/spi/ti_qspi.c:259:
+ }$
ERROR: code indent should use tabs where possible
#257: FILE: drivers/spi/ti_qspi.c:261:
+ if (bitlen == 0)$
WARNING: please, no spaces at the start of a line
#257: FILE: drivers/spi/ti_qspi.c:261:
+ if (bitlen == 0)$
ERROR: code indent should use tabs where possible
#258: FILE: drivers/spi/ti_qspi.c:262:
+ return -1;$
WARNING: please, no spaces at the start of a line
#258: FILE: drivers/spi/ti_qspi.c:262:
+ return -1;$
total: 26 errors, 26 warnings, 0 checks, 177 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX
MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE
/home/wd/Mail/U-Boot/16312 has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Administration: An ingenious abstraction in politics, designed to
receive the kicks and cuffs due to the premier or president.
- Ambrose Bierce
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
