On 07/11/2013 04:31 AM, Sricharan R wrote: > On Thursday 11 July 2013 02:25 PM, Roger Quadros wrote: >> On 07/11/2013 11:35 AM, Sricharan R wrote: >>> On Thursday 11 July 2013 01:28 PM, Roger Quadros wrote: >>>> On 07/11/2013 06:51 AM, Lokesh Vutla wrote: >>>>> On Thursday 11 July 2013 01:35 AM, Dan Murphy wrote: >>>>>> * Enable the OMAP5 EHCI host clocks >>>>>> * Add OMAP5 EHCI register definitions >>>>>> * Add OMAP5 ES2 host revision >>>>>> >>>>>> Signed-off-by: Dan Murphy <dmur...@ti.com> >>>>>> --- >>>>>> arch/arm/cpu/armv7/omap5/hw_data.c | 13 ++++++++++ >>>>>> arch/arm/include/asm/arch-omap5/clock.h | 6 +++++ >>>>>> arch/arm/include/asm/arch-omap5/ehci.h | 43 >>>>>> +++++++++++++++++++++++++++++++ >>>>>> arch/arm/include/asm/ehci-omap.h | 1 + >>>>>> drivers/usb/host/ehci-omap.c | 2 +- >>>>>> 5 files changed, 64 insertions(+), 1 deletion(-) >>>>>> create mode 100644 arch/arm/include/asm/arch-omap5/ehci.h >>>>>> >>>>>> diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c >>>>>> b/arch/arm/cpu/armv7/omap5/hw_data.c >>>>>> index 56cf1f8..055f058 100644 >>>>>> --- a/arch/arm/cpu/armv7/omap5/hw_data.c >>>>>> +++ b/arch/arm/cpu/armv7/omap5/hw_data.c >>>>>> @@ -412,6 +412,8 @@ void enable_basic_clocks(void) >>>>>> (*prcm)->cm_l4per_gpio4_clkctrl, >>>>>> (*prcm)->cm_l4per_gpio5_clkctrl, >>>>>> (*prcm)->cm_l4per_gpio6_clkctrl, >>>>>> + (*prcm)->cm_clksel_usb_60mhz, >>>>>> + (*prcm)->cm_l3init_hsusbtll_clkctrl, >>>>> guard this with CONFIG_USB_EHCI please or it ll >>>>> throw an error for DRA7xx boards. >>>> why is DRA7xx using omap5/hw_data.c? >>>> >>>> doesn't it qualify for its own SoC directory? >>> We tried to keep common things for OMAP5/DRA intact and >>> added the difference. The above clocks list was same for both. >>> In fact there is no armv7/dra directory at all. >> If there is no directory, it could be created I suppose. >> IMHO it would become ugly soon if it doesn't have its own hw_data. > I am not much against it, it might look clean but would result in some code > duplication. I feel we should do it if we add another DRA variant. > > Regards, > Sricharan For now I will wrap it in CONFIG_USB_EHCI_OMAP until the dra7xx is figured out.
+1 to a separate SoC directory for dra7xx Dan -- ------------------ Dan Murphy _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
