Wolfgang Denk wrote: > Dear Tom Rix, > > In message <1238602273-27252-1-git-send-email-tom....@windriver.com> you > wrote: > >> Zoom2 is a new board from Texas Instruments and LogicPD >> This is the product description >> http://www.logicpd.com/products/development-kits/texas-instruments-zoom%E2%84%A2-omap34x-ii-mdp >> >> This patch provides a zoom2 base target by copying zoom1 and by making some >> obvious changes. This target compiles but does not yet run. >> >> To configure, run >> make omap3_zoom2_config >> > ... > >> diff --git a/board/omap3/zoom2/zoom2.c b/board/omap3/zoom2/zoom2.c >> new file mode 100644 >> index 0000000..f861691 >> --- /dev/null >> +++ b/board/omap3/zoom2/zoom2.c >> > ... > >> +/****************************************************************************** >> + * Routine: board_init >> + * Description: Early hardware init. >> + >> *****************************************************************************/ >> > > Here and everywhere else: incorrect multiline comment style. Please > fix everywhere. > > > This is common in all the omap3 board files. I will fix these as well. >> diff --git a/include/configs/omap3_zoom2.h b/include/configs/omap3_zoom2.h >> new file mode 100644 >> index 0000000..9ea8ea0 >> > ... > >> +/* Clock Defines */ >> +#define V_OSCK 26000000 /* Clock output from T2 >> */ >> > > Here and in some other places: line too long. Please fix everywhere. > > > > OK > Best regards, > > Wolfgang Denk > >
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
