Hi Alison,

On Wednesday, May 29, 2013 7:52:33 AM, Wang Huan-B18965 wrote:
> Hi, Benoit,
> 
> > > +
> > > +#define CONFIG_CMD_PING
> > > +#define CONFIG_CMD_DHCP
> > > +#define CONFIG_CMD_MII
> > > +#define CONFIG_CMD_NET
> > > +#define CONFIG_FEC_MXC
> > > +#define CONFIG_MII
> > > +#define IMX_FEC_BASE                     ENET_BASE_ADDR
> > > +#define CONFIG_FEC_XCV_TYPE              RMII
> > > +#define CONFIG_FEC_MXC_PHYADDR          0
> > 
> > Why don't you add support for the 2nd FEC? Do you plan to do it later?
> [Alison Wang] In u-boot, one FEC is enough for user. We do not plan to do it
> later.
> > 
> > > +#define CONFIG_PHYLIB
> > > +#define CONFIG_PHY_MICREL
> > > +
> > > +#define CONFIG_BOOTDELAY         3
> > > +
> > > +#define CONFIG_SYS_TEXT_BASE             0x3f008000
> > > +
> > > +/* Miscellaneous configurable options */
> > > +#define CONFIG_SYS_LONGHELP              /* undef to save memory */
> > > +#define CONFIG_SYS_HUSH_PARSER           /* use "hush" command parser
> > */
> > > +#define CONFIG_SYS_PROMPT_HUSH_PS2       "> "
> > > +#define CONFIG_SYS_PROMPT                "Vybrid U-Boot > "
> > > +#undef CONFIG_AUTO_COMPLETE
> > > +#define CONFIG_SYS_CBSIZE                256     /* Console I/O Buffer 
> > > Size */
> > > +#define CONFIG_SYS_PBSIZE                \
> > > +                 (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
> > > +#define CONFIG_SYS_MAXARGS               16      /* max number of 
> > > command args
> > */
> > > +#define CONFIG_SYS_BARGSIZE              CONFIG_SYS_CBSIZE
> > > +
> > > +#define CONFIG_CMD_MEMTEST
> > > +#define CONFIG_SYS_MEMTEST_START 0x80010000
> > > +#define CONFIG_SYS_MEMTEST_END           0x87C00000
> > 
> > Please make sure to have runtime-tested this address range with the
> > mtest command since bad mtest addresses are the reason why
> > CONFIG_CMD_MEMTEST has been removed from the default commands.
> [Alison Wang] Thanks for your reminder, we have tested.

OK, then, for this patch:
Reviewed-by: Benoît Thébaudeau <benoit.thebaud...@advansee.com>

Best regards,
Benoît
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to