On Tue, May 14, 2013 at 05:13:44PM +0200, Ruud Commandeur wrote:
> Hi Tom,
> 
> It has become a bit quiet on this thread, but I just made the changes as I 
> suggested, including some other fixes. Here is what I did:
> 
> > Added a check for blkcnt > 0 in mmc_write_blocks (drivers/mmc.c). By doing 
> > this in the lowest level function, it also solves a hangup if for instance 
> > an "mmc write" command is given with a block count being 0.
> 
> > Solved a checksum issue in fs/fat/fat.c. The mkcksum has const char 
> > arguments with a size specifier, like "const char name[8]". In the 
> > function, it is assumed that sizeof(name) will have the value 8, but this 
> > is not the case (at least not for the compiler I use and I guess not 
> > according to ANSI C). This causes "long filename checksum errors" for each 
> > fat file listed or written.
> 
> > Made some changes to fs/fat/fat_write.c. Fixed testing fat_val for 
> > 0xffff/0xfff8 and 0xfffffff/0xffffff8 by adding the corresponding fatsize 
> > in the test (as I read in earlier posts) and some changes in debug output.
> 
> I have used this for a few weeks now without any mmc and fat related problems 
> sofar.
> 
> I do have a patch file for this. Should I post this with a "Signed-off-by 
> (etc, etc)", or would you like to receive and review this patch file yourself 
> first?

Please post it with a Signed-off-by line for review on the list, thanks!

-- 
Tom

Attachment: signature.asc
Description: Digital signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to