On 03/12/2013 10:17 AM, Tom Warren wrote:
> SDIO1 (the SD-card slot on Dalmore) needs to have its pads setup
> before the MMC driver is added.
> diff --git a/board/nvidia/dalmore/dalmore.c b/board/nvidia/dalmore/dalmore.c
> + /* Initialize any non-default pad configs (APB_MISC_GP regs) */
> + padgrp_config_table(dalmore_padctrl, ARRAY_SIZE(dalmore_padctrl));
Given that you're only using this table for the very first time here ...
> diff --git a/board/nvidia/dalmore/pinmux-config-dalmore.h
> b/board/nvidia/dalmore/pinmux-config-dalmore.h
> static struct padctrl_config dalmore_padctrl[] = {
> /* (_padgrp, _slwf, _slwr, _drvup, _drvdn, _lpmd, _schmt, _hsm) */
> + DEFAULT_PADCFG(SDIO3, SDIOCFG_DRVUP_SLWF, SDIOCFG_DRVDN_SLWR, \
> + SDIOCFG_DRVUP, SDIOCFG_DRVDN, NONE, DISABLE, ENABLE),
> };
... and it was empty before now, I'd be inclined to remove the *dalmore*
files from the Tegra114 pinmux series that implemented
padgrp_config_table(), and just do all the Dalmore-specific stuff in
this patch.
But it's not a big deal.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
