Thanks for the review, Stefano. On 02/12/2013 02:12 AM, Stefano Babic wrote:
On 30/01/2013 19:10, Eric Nelson wrote:This patch adds support for the Nitrogen6X board(s) from Boundary Devices. The boards are based on the i.MX6x processor family with two major variants: i.MX6Quad/6Dual i.MX6Dual-Lite/6SoloMore specifically, the board variations are: nitrogen6q i.MX6Q/6D 1GB nitrogen6dl i.MX6DL 1GB nitrogen6s i.MX6S 512MB nitrogen6q2g i.MX6Q/6D 2GB nitrogen6dl2g i.MX6DL 2GB nitrogen6s1g i.MX6S 1GB Refer to http://boundarydevices.com/products/ for details.Hi Eric, some general comments in praparation your V2. I have only some minor points. - Try to split your patch in several patches, if possible. The patch covers different issues and the series will be easy to be review. This is mainly for the changes outside boards/boundary - I know it is not easy to split the rest.
Understood. I submitted this as one big patch to show things in context.
- I agree you put your script in the board directory instead opf trying to use CONFIG_EXTRA_ENV_SETTINGS.
Cool.
- Agree with the split of the configuration data (clocks.cfg and ddr setup). The same mechanism can be reused for other boards, too.
Thanks. Note that there's a bit of hand-waving for things that don't quite fit, but the essential differences in memory setup are properly partitioned.
- and agree with the nomenclature. My +1 to rename mx6x_pins.h to mx6q_pins.h as you suggest in the cover letter.
Will do. I'll submit that before V2 of Nitrogen6X support so it can be discussed separately. Regards, Eric _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
