On Tue, 8 Jan 2013 10:24:05 -0800 Barry Grussling <ba...@grussling.com> wrote:
> While trying to bring up a custom MPC8308 based board I found > that the clocking was wrong. The comment in > include/configs/mpc8308_p1m.h led me to believe > setting HRCWH_PCI_HOST and HRCWH_PCI1_ARBITER_ENABLE in the > CONFIG_SYS_HRCW_HIGH should allow the system to work, but on > my newer version of the 8308 this is not working. Setting > the HRCWH_PCI_HOST bit (which doesn't exist according to the manual) > doesn't latch, and as such the im->reset.rcwh & HRCWH_PCI_HOST test > in speed.c fails. Since this board is running off the I don't have an 8308 and nothing relevant shows up in the errata, so modulo modifying the rcwh read with an i/o accessor (in_be32) and it still failing, we ought to amend the comment with this new info. cc'ing Ilya, in case he can test on his 8308. > +#elif defined(CONFIG_83XX_CLKIN) && defined(CONFIG_MPC8308) > + /* 8308 doesn't have the HRCWH_PCI_HOST, but should > + * run off the CONFIG_83XX_CLKIN */ > + pci_sync_in = CONFIG_83XX_CLKIN / (1 + clkin_div); /* * this is the correct multi-line comment * style */ also align comment and code, and omit trailing whitespace: ERROR: trailing whitespace #119: FILE: arch/powerpc/cpu/mpc83xx/speed.c:164: +^I/* 8308 doesn't have the HRCWH_PCI_HOST, but should $ Thanks, Kim _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
