On Mon, Dec 10, 2012 at 07:09:55PM -0600, Scott Wood wrote: > On 12/10/2012 09:24:32 AM, Pantelis Antoniou wrote: > >Introduce on-the fly DFU NAND support. > > > >Signed-off-by: Pantelis Antoniou <pa...@antoniou-consulting.com> > >--- > > drivers/dfu/Makefile | 1 + > > drivers/dfu/dfu.c | 7 ++ > > drivers/dfu/dfu_nand.c | 194 > >+++++++++++++++++++++++++++++++++++++++++++++++++ > > include/dfu.h | 23 ++++++ > > 4 files changed, 225 insertions(+) > > create mode 100644 drivers/dfu/dfu_nand.c > > What is DFU? I don't see anything in README or doc/, despite there > already being CONFIG symbols for it.
Pah... Yes, we let that one slip past. DFU is USB Device Firmware
Upgrade, something from the openmoko folks (roughly) that various
devices support for sending payload via USB to be written to $flash.
> >+static int nand_block_op(enum dfu_nand_op op, struct dfu_entity *dfu,
> >+ u64 offset, void *buf, long *len)
> >+{
> >+ char cmd_buf[DFU_CMD_BUF_SIZE];
> >+ u64 start, count;
> >+ int ret;
> >+ int dev;
> >+ loff_t actual;
> >+
> >+ /* if buf == NULL return total size of the area */
> >+ if (buf == NULL) {
> >+ *len = dfu->data.nand.size;
> >+ return 0;
> >+ }
> >+
> >+ start = dfu->data.nand.start + offset + dfu->bad_skip;
> >+ count = *len;
> >+ if (start + count >
> >+ dfu->data.nand.start + dfu->data.nand.size) {
> >+ printf("%s: block_op out of bounds\n", __func__);
> >+ return -1;
> >+ }
> >+ dev = nand_curr_device;
> >+ if (dev < 0 || dev >= CONFIG_SYS_MAX_NAND_DEVICE ||
> >+ !nand_info[dev].name) {
> >+ printf("%s: invalid nand device\n", __func__);
> >+ return -1;
> >+ }
> >+
> >+ sprintf(cmd_buf, "nand %s %p %llx %llx",
> >+ op == DFU_OP_READ ? "read" : "write",
> >+ buf, start, count);
> >+
> >+ debug("%s: %s 0x%p\n", __func__, cmd_buf, cmd_buf);
> >+ ret = run_command(cmd_buf, 0);
>
> Why not use the C interface to NAND?
>
> >+ /* find out how much actual bytes have been written */
> >+ /* the difference is the amount of skip we must add from now on
> >*/
> >+ actual = nand_extent_skip_bad(&nand_info[dev], start, count);
>
> ...especially since you already need to interact with it here?
I've been talking with Pantelis about this as well and in short, this
series adds NAND support ala MMC (which is to say, (ab)using the command
interface). I think he was thinking we need a bit more generic help to
avoid having to duplicate the code the command interface also uses
(state, sanity checking), iirc.
--
Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
