On Thu, 19 Feb 2009, Wolfgang Denk wrote: > Dear k...@koi8.net, > > In message <pine.lnx.4.64ksi.0902181434310.5...@home-gw.koi8.net> you wrote: > > > > Yes, it is possible, but it is not the best approach. Most of those macros > ... > > That means that implementation is much worse than _EXISTING_ one. And out of > > decent and much worse one which one would you choose? > > Define "decent". It seems we have a different opintion abot such a > definition. > > And define "much worse", please. How much wors is this (in bytes) for > a single adapter, and for 2, 3, or 5?
I already gave an estimate. It is at very least not better. It doesn't give any benefits and introduces some problems. Yes, there is already a tradeof and all our weaknesses are just an extension of our advantages but in this case there is no advantages... > > > This is your implementation. It is not the only possible implemen- > > > tation. Please try and open your mind to discuss alternative > > > possibilities as well. > > > > No, it is NOT my implementation. It is _EXISTING_ driver in the main tree. I > > did _NOT_ change the driver, I just made several copies of it. > > Yes, and this is what I'm complaining about. The whole idea behind > software engineering is not to copy code. > > > Well, it looks like it is you are Russian, not me :) It is well known > > Maybe I am; kind of, at least :-) :) > > Russian passion to scrap everything and design a Universal Server Of > > Everything from scratch :) I'm trying to avoid that... > > Me too. > > > > Call it what you want, I call it duplication of code. > > > > It might be a duplication of SOURCE TEXT, but not CODE. > > Source text compiles to object code, doesn't it? Not always. E.g. defines never compile to object code. Function declarations don't compile to object code. And so on... > > > > > Is this theory or did you perform code size measurements? > > > > > > > > It is obvious. Furthermore, it doesn't make sence to count size > > > > difference > > > > here because it is miniscule -- how many I2C adapters do we have on a > > > > board? > > > > > > It is obvious. Famous last words again. > > > > Eh, do you think anyone really has time to make such comparisons to find out > > that size difference is zero? > > You have the code base ready available and can compile and measure > it, can't you? > > If you base your argumentation on such claims, you better have prove > for it. There is a threshhold. Yes, I should've proved it if it had been very different. But in this case the difference is minimal and not worth an effort. --- ****************************************************************** * k...@home KOI8 Net < > The impossible we do immediately. * * Las Vegas NV, USA < > Miracles require 24-hour notice. * ****************************************************************** _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
