On Mon, 16 Feb 2009, Wolfgang Denk wrote:

> Dear k...@koi8.net,
> 
> In message <pine.lnx.4.64ksi.0902121413560.21...@home-gw.koi8.net> you wrote:
> >
> ...
> > -   if (eeprom_read (dev_addr, 0, i2c_buffer, 
> > CONFIG_SYS_IVM_EEPROM_MAX_LEN) != 0) {
> > -           printf ("Error reading EEprom\n");
> > -           return -2;
> > +   if (eeprom_read (tmp, 0, i2c_buffer, CONFIG_SYS_IVM_EEPROM_MAX_LEN) != 
> > 0) {
>                        ^^ space kept
> > +           printf("Error reading EEprom\n");
>                      ^^ space deleted.
> > +           return(-2);
> 
> Please do not mix coding style changes with functional changes in one
> patch. And please do not change style at random - leaving spaces here
> but removing them there. At least use a consistent style.

OK, I won't touch those.

---
******************************************************************
*  k...@home    KOI8 Net  < >  The impossible we do immediately.  *
*  Las Vegas   NV, USA   < >  Miracles require 24-hour notice.   *
******************************************************************
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to