Hello Kim,
Kim Phillips wrote:
> On Wed, 11 Feb 2009 19:26:22 +0100
> Heiko Schocher <h...@denx.de> wrote:
>
>> + switch (svid) {
>> + case 0x0020:
>
> 'case' should be aligned directly under 'switch'.
>
>> +++ b/cpu/mpc83xx/start.S
>> @@ -137,6 +137,11 @@ get_pvr:
>> mfspr r3, PVR
>> blr
>>
>> + .globl get_svr
>> +get_svr:
>> + mfspr r3, SVR
>> + blr
>> +
>
> on a ./MAKEALL SIMPC8313_LP, I'm getting:
>
> powerpc-linux-gnu-ld: NAND bootstrap too big
> powerpc-linux-gnu-ld: NAND bootstrap too big
> make[1]: *** [/home/r1aaha/git/u-boot/nand_spl/u-boot-spl] Error 1
> make: *** [nand_spl] Error 2
> make: *** Waiting for unfinished jobs....
> powerpc-linux-gnu-size: './u-boot': No such file
Hmm.. with actual u-boot I get for this board (without my patches):
[...@pollux u-boot]$ ./MAKEALL SIMPC8313_LP
...Large Page NAND...Configuring for SIMPC8313 board...
In file included from /home/hs/U-Boot-Patches/u-boot/include/config.h:5,
from include/common.h:35:
/home/hs/U-Boot-Patches/u-boot/include/configs/SIMPC8313.h:81:1: warning:
"CONFIG_MAX_MEM_MAPPED" redefined
In file included from /home/hs/U-Boot-Patches/u-boot/include/config.h:4,
from include/common.h:35:
/home/hs/U-Boot-Patches/u-boot/include/asm/config.h:28:1: warning: this is the
location of the previous definition
In file included from /home/hs/U-Boot-Patches/u-boot/include/config.h:5,
from start.S:30:
[...]
also with actual u-boot-mpc83xx.git:
[...@pollux u-boot-mpc83xx]$ ./MAKEALL SIMPC8313_LP
...Large Page NAND...Configuring for SIMPC8313 board...
In file included from /home/hs/U-Boot-Patches/u-boot-mpc83xx/include/config.h:5,
from include/common.h:35:
/home/hs/U-Boot-Patches/u-boot-mpc83xx/include/configs/SIMPC8313.h:81:1:
warning: "CONFIG_MAX_MEM_MAPPED" redefined
In file included from /home/hs/U-Boot-Patches/u-boot-mpc83xx/include/config.h:4,
from include/common.h:35:
[...]
> and I think (because I haven't verified it), it's because of the above
> addition to start.S; Can you please look into moving this fn elsewhere
Yes, that seems plausible, but see above, I didn;t get this error
with actual u-boot-mpc83xx.git nor with actual u-boot.
> - see commit 455a4691 and test rebuilding the SIMPC board?
Yes, I try to move get_svr to cpu.c?
thanks
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
