On Wed, 4 Feb 2009, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <pine.lnx.4.64.0902041540350.6...@axis700.grange> you wrote: > > This is a driver for the S6E63D6 SPI OLED display controller from Samsung. > > It only provides access to controller's registers so the client can freely > > configure it. > > > > Signed-off-by: Guennadi Liakhovetski <l...@denx.de> > ... > > diff --git a/drivers/video/Makefile b/drivers/video/Makefile > > index 7fba29f..a7dc74c 100644 > > --- a/drivers/video/Makefile > > +++ b/drivers/video/Makefile > > @@ -34,6 +34,7 @@ COBJS-$(CONFIG_VIDEO_SED13806) += sed13806.o > > COBJS-$(CONFIG_SED156X) += sed156x.o > > COBJS-$(CONFIG_VIDEO_SM501) += sm501.o > > COBJS-$(CONFIG_VIDEO_SMI_LYNXEM) += smiLynxEM.o > > +COBJS-$(CONFIG_DISPLAY_S6E63D6) += s6e63d6.o > > Please keep lists sorted. > > And maybe we can omit the "DISPLAY_" part?
Well, I tried to follow the CONFIG_VIDEO_* style, but can remove, sure. > > +++ b/drivers/video/s6e63d6.c > ... > > +/* Hardware selected value - 0 or 0x4 */ > > +#define ID 0 > > Should this go into the board config file? Can do. > > +/* Index and param differ in Register Select bit */ > > +int s6e63d6_index(struct s6e63d6 *data, u8 idx) > > +{ > > + return send_word(data->slave, 0, idx); > > +} > > + > > +int s6e63d6_param(struct s6e63d6 *data, u16 param) > > +{ > > + return send_word(data->slave, 2, param); > > +} > > + > > +int s6e63d6_init(struct s6e63d6 *data) > > +{ > > + data->slave = spi_setup_slave(data->bus, data->cs, 100000, SPI_MODE_3); > > + if (!data->slave) > > + return 1; > > + > > + return 0; > > +} > > static? or inline? Neither, nor. It is declared in the header in this patch and called in [PATCH 9/9]. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot