>> +int do_bootm_subcommand (cmd_tbl_t *cmdtp, int flag, int argc,
>> char *argv[])
>> +{
>> + int ret = 0;
>> +
>> + /* start */
>> + if (argv[1][0] == 's') {
>
> I think just matching on the first letter is to restrictive; we'll end
> up with artificical command "names" that nobody can remember.
>
>> + if (!images.valid) {
>> + printf("Need to call %s start first\n", argv[0]);
>> + return 1;
>> + }
>
> We should probably set up a small state machine.
A small state machine for what?
>> + else if (argv[1][0] == 'i') {
>
> And we need comments what all this means. WTF is 'i' ?
initrd, I can change it to 'r' for ramdisk if that is better.
>> +#if 0
>> +are these really common ??? or is there any harm??
>> + /* bd_t setup */
>> + else if (argv[1][0] == 'p') {
>> + }
>
> Yes, we still have plenty of systems running in the field with
> arch/ppc and even with 2.4 kernels.
>
>> + /* prep os */
>> + else if (argv[1][0] == 'p') {
>> + return do_bootm_linux(BOOT_OS_PREP, argc, argv, &images);
>> + }
>
> We already had 'p' above.
- k
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
