Dear Guennadi Liakhovetski, In message <[EMAIL PROTECTED]> you wrote: > > So, no, this is not because I didn't like somebody else's coding style. > This is because with NAND addition this function would become an > absolutely unreadable monster. So, I would consider this patch a > readability improvement.
But you are duplicating code. It may be just 20 lines or so, but the better approach would be to leave the common code as is and factor out two new functions being called from the common code. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] My brother sent me a postcard the other day with this big sattelite photo of the entire earth on it. On the back it said: "Wish you were here". - Steven Wright _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
