Dear Peter Tyser,
In message <[EMAIL PROTECTED]> you wrote:
> > what is the purpose of this patch? As far as I can see we gain
> > nothing, but we lose on memory footpint. I guess there is some
> > problem you're trying to fix, but you did not mention it?
>
> I've added a basic "debug serial console" which relies on this patch.
> The debug console is a simple command prompt which allows the user to
> issue commands before relocating to SDRAM. We've found this feature
> very useful for operations such as initially programming SPD data,
> debugging hardware issues (SDRAM/I2C). I'll submit the debug console
> patches shortly.
OK, I think what you're trying to do.
> I'm not sure if the debug console will be accepted to mainline, but I
> think this patch alone is an improvement over the current implementation
Frankly, I don't think so - it just makes the code bigger for no good
use to 99.9% of the users.
> of using a global string and multiple external console_buffer
> references. I've always thought global variables should be avoided if
> there is a reasonable alternative
But this is a boot loader, and size matters.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Lady Nancy Astor:
"Winston, if you were my husband, I'd put poison in your coffee."
Winston Churchill:
"Nancy, if you were my wife, I'd drink it."
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
