> On Mar 19, 2015, at 8:41 AM, Christopher Armstrong <ra...@twistedmatrix.com> > wrote: > > >> On Mar 19, 2015, at 4:45 AM, Adi Roiban <a...@roiban.ro> wrote: >> >>> OK, cool. I didn't realize that was ready for review. I am liking the >>> process we have for Mimic for flagging PRs with keywords - >>> https://github.com/rackerlabs/mimic/pulls - but this needs automation so as >>> not to be unfriendly to non-committer contributors. >>> >>> I'll try to get to it by the end of the week. >> >> For twistedchecker I start using tags ... but I don't have permissions >> for twisted-infra repos. >> >> Yes. GitHub PR are nice but horrible for implementing anything formal >> on top of it. >> >> I was preparing to suggest someting similar also for Trac as sometimes >> I am not sure if a comment is 'do minor changes and merge' or 'do >> minor change and send them for review' >> >> My suggestion is this: >> >> when a PR is ready for review the author should leave a comment >> containing the `needs-review` marker. This will send a hook and a >> custom hook server will update the tags of the ticket. >> > > > I suggest making the default, tagless state of a PR mean “in review”, for a > couple of reasons: > > - having labels for both `needs-changes` and `in-review` means you can enter > an invalid state where both labels are applied > - if the automation loses track of a PR, we don’t want people filtering only > for PRs with `label:in-review` and missing out on the forgotten PR > > so I propose tagless PRs be considered “in review”, and a label only for > `needs-changes`.
I like seeing the big green "ready for review" on Mimic PRs; it's more eye-catching. We can have 2 labels though, so that if the automation breaks, we can have a periodic check that adds "in-review" to everything un-labeled. -g _______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
