> On Mar 19, 2015, at 10:46 AM, HawkOwl <hawk...@atleastfornow.net> wrote:
> 
> 
>> On 19 Mar 2015, at 23:41, Christopher Armstrong <ra...@twistedmatrix.com> 
>> wrote:
>> 
>> I suggest making the default, tagless state of a PR mean “in review”, for a 
>> couple of reasons:
>> 
>> - having labels for both `needs-changes` and `in-review` means you can enter 
>> an invalid state where both labels are applied
>> - if the automation loses track of a PR, we don’t want people filtering only 
>> for PRs with `label:in-review` and missing out on the forgotten PR
>> 
>> so I propose tagless PRs be considered “in review”, and a label only for 
>> `needs-changes`.
> 
> Only people with special access can modify labels, though?


Right, and Adi suggests a bot for managing those labels — I’m not disagreeing 
with that point in general, just the details about which tags there are.

-radix


_______________________________________________
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Reply via email to