On 08 Sep 10:05, Cédric Krier wrote: > On 24 Jul 11:08, Cédric Krier wrote: > > On 24 Jul 01:13, Cédric Krier wrote: > > > On 24 Jul 00:53, Mathias Behrle wrote: > > > > * Cédric Krier: " Re: [tryton-dev] Toward a working multi-company" > > > > (Wed, 23 Jul > > > > 2014 22:54:04 +0200): > > > > > > > > > On 03 Jul 09:59, Cédric Krier wrote: > > > > > > Hi, > > > > > > > > > > > > I was requested to provide a plan for multi-company as I say in > > > > > > issue3974 [1]. > > > > > > > > > > > > TL;DR: drop record rule, add domain on fields > > > > > > > > > > Here is > > > > > > > > > > - the issue: https://bugs.tryton.org/issue4080 > > > > > - the review: http://codereview.tryton.org/10461002/ > > > > > > > > Much appreciated! As we are at the point to make the decision for a > > > > customer to > > > > use a multi-company in favor of a multi-database setup I want to ask, > > > > if we can > > > > supposedly rely on this feature in the future. If there are > > > > uncertainties about > > > > the persistance of this feature, please let us know. > > > > > > For me, it is the way to go but still waiting feedback from others. > > > But about "feature" as you can see it is more about removing rules than > > > adding new stuff. The new code is mainly adding missing domain (should > > > be there in any cases) or missing company field and in few places it > > > just hard code the previous rule because anything else don't make sense > > > (ex: stock quantity) > > > > Also this review needs more testing especially for new cases, like > > creating a sale for an other company then the current user one. > > For me, the state of the patch is good for inclusion so I plan to push > it by the end of the week of I get no bad feedbacks.
So I give up for this patch.
So to be clear, multi-company will still not work for the next release.
The issues are:
- property field: it will not be possible to have correct
multi-company when we still have those shitty fields.
- context: in base we should never depend on context.
- user.company: in base we should never depend on this.
--
Cédric Krier - B2CK SPRL
Email/Jabber: cedric.kr...@b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/
pgpU8Oc4EuyZH.pgp
Description: PGP signature
