Hi Thank you for all kind words on my work. I am Java programmer, but KDE enthusiast. I've recently dropped KMail for its bloated Akonadi eating way too much resources for my two IMAP accounts. So I've evaluated Trojita and I like it. It has a few glitches, but message counter was crucial for me. I have a two year experience with C++ so I did my best on this.
Thank you for committing guidelines. I naively thought that github interface will suffice, but it won't :) I'll try to stick guidelines you've provided. I've read your all cases and I think that this patch can be abandoned. Instead I propose other solution: 1. Include all folders recursively 2. But only subscribed folders 3. With an opt-out option possible on every folder I think that would cover all your cases. Especially the one, when you can still subscribe a folder without counting it and you can exclude counting on each level of a tree. Excluded folders list would be kept in configuration. If you're all satisfied I'd try to implement that in my spare time. Regards, Tomasz Kalkosiński 2014/1/2 Kevin Krammer <kram...@kde.org> > On Thursday, 2014-01-02, 19:48:31, Jan Kundrát wrote: > > On Thursday, 2 January 2014 10:30:38 CEST, Tomasz Kalkosiński wrote: > > > I've submitted a pull request on github to improve systray unread count > > > here: https://github.com/jktjkt/trojita/pull/5 . Please review and > give > > > > me > > > > > a feedback if you'd like to receive more pull requests this way. > > > > Hi Tomasz, > > first of all, welcome aboard. Introducing yourself with a patch is a > > stylish way of getting involved :), congratulations for that. In KDE, the > > preferred form of contributing is via Reviewboard [1]. It doesn't have a > > git integration, though, so please add an info about where you have > pushed > > your changes to in any review requests you create. I hope we'll be able > to > > migrate to Gerrit in a couple of months, but it isn't there just yet. > > Not the same thing, but it is possible to automate the review request > interaction by using the REVIEW keyword in the commit log message. > > basically a line > REVIEW: reviewnumber > > will trigger a commit hook that marks the reviewrequest as submitted (and > adds > a review with the SHA1 if I remember correctly). > > It is also possible to close and comment on a bugzilla entry (using the BUG > keyword) and to send the commit log+hash to emails using the CCMAIL > keyword. > > See > > http://techbase.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages > > I think there is a commit template somewhere that contains all of these. > > Cheers, > Kevin > -- > Kevin Krammer, KDE developer, xdg-utils developer > KDE user support, developer mentoring >
