On Thursday, 2 January 2014 10:30:38 CEST, Tomasz Kalkosiński wrote:
I've submitted a pull request on github to improve systray unread count
here: https://github.com/jktjkt/trojita/pull/5 . Please review and give
me
a feedback if you'd like to receive more pull requests this way.
Hi Tomasz,
first of all, welcome aboard. Introducing yourself with a patch is a
stylish way of getting involved :), congratulations for that. In KDE, the
preferred form of contributing is via Reviewboard [1]. It doesn't have a
git integration, though, so please add an info about where you have pushed
your changes to in any review requests you create. I hope we'll be able to
migrate to Gerrit in a couple of months, but it isn't there just yet.
Regarding the change -- it's a good idea, in my opinion. However, my use
case is that I essentially have three classes of mailboxes:
a) Those that I don't care about at all, and therefore are not subscribed.
My GUI is configured to only show subscribed mailboxes.
b) Those that I visit every now and then, so they're subscribed. On the
other hand I don't have to react to new arrivals immediately, so I don't
need a notification in the systray when a new message arrives.
c) The INBOX which contains mails I have to take an action on.
Right now, the Qt's interest mailing list is among the folders I'm
subscribed to. It contains 35665 unread mails, and I have no intention to
read them, ever. I prefer not to mark them as read because that's a useful
information -- it might be interesting to know whether I read that
particular thread when I made my semi-daily visit to the ML to see whether
anything interesting is going on.
If this change went in as-is, the systray message count would be completely
useless to me, so I cannot accept it as-is. What might work well is a
setting option for toggling whether to include just the INBOX, or all
subscribed mailboxes in there.
Another limitation of the patch is that it does not support nested
mailboxes at all. This is a tricky part -- on one hand, it makes sense to
be able to discover e.g. my dev.gentoo.gentoo-dev mailbox ("." is the
hierarchy separator), but on the other hand it is not acceptable to blindly
expand the full folder hierarchy upon each reconnect because there are IMAP
servers which can e.g. export a huge usenet archive in some namespace. I
don't know how to tackle this, and opinions are much welcome.
Cheers,
Jan
[1] https://git.reviewboard.kde.org/groups/trojita/
--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
