DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=33650>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=33650 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16121|0 |1 is obsolete| | Attachment #16122|0 |1 is obsolete| | Attachment #16123|0 |1 is obsolete| | Attachment #16124|0 |1 is obsolete| | ------- Additional Comments From [EMAIL PROTECTED] 2005-08-20 04:18 ------- Created an attachment (id=16126) --> (http://issues.apache.org/bugzilla/attachment.cgi?id=16126&action=view) proposed patches for Options.java, JspC.java, EmbeddedServletOptions.java and TagLibraryInfoImpl.java in cvs diff format This patch is about caching the TreeNode tld in TagLibraryInfoImpl. Because the profiling results show the repeating parsing of the same TLD has dominated the precompilation process, this change would make the jasper works much better on a large Ant build :-) (I would also submit the different profiling snapshots before and after the code changes). Here is what I basically did: 1. Options.java: add two public functions in Options interface. One is isCacheTldXml(), and the other is Map getCachedTldXmlMap(). The parsed TLD XML data is cached in a Map(String uri, TreeNode tld). 2. JspC.java: add switch "-cacheTldXml" and implement the two functions defined in Options. The cacheTldXml is defaulted to true but the users can set it. 3. EmbeddedServletOptions.java: add boolean cacheTldXml and implement the two functions. As EmbeddedServletOptions is called by run-time compilation, cacheTldXml is set to false by default. 4. TagLibraryInfoImpl.java: add an if-else clause in parseTld to distinguish command-line build and run-time build. If the CompilerContext is JspC, try to get the TreeNode from cache first; otherwise call parseXMLDocument to parse the TLD directly. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
