Costin Manolache wrote:

Comments?


Looks good.

It seems it still does a lot of String operations in native - unlike SWT for example, where it's almost always byte[].

Well the strings are used for non-frequent operations like file opening etc, for which you'll probably use String.getBytes() anyhow. The apr has a nice feature that its file operation supports UTF, so the cost is minimal thought. Perhaps only puts and similar operations should be changed to byte. Everything else is byte[].

Also the typical memcpy, etc should be included somewhere to allow data to move from/to the pool and java heap.


Well, apr pools should be used only for allocating apr object not memory itself.

Why not checking it in j-t-c ?

Just to make sure - you expect it to also have non-apr native methods ?


Yes. Inside file win32,netware,unix. For start it will be mostly the code already written for either used by Apache2 like setgrp, setuid when launching child process.

That code should really be minimal and agreed in front.
I don't wish that this ends like a messy repository for
lots of junk code.

Mladen.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to