From: Remy Maucherat [mailto:[EMAIL PROTECTED] > Sent: Friday, April 02, 2004 8:30 PM > To: Tomcat Developers List > Subject: Re: cvs commit: > jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina > /core ApplicationContext.java > > Mark Thomas wrote: > > > OK then. Now for the tricky bit. Bug 13040 > > (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13040) > highlights a rather > > knotty problem. Having mulled this over for the last few > days I have come to the > > conclusion that we should be using equals() rather than startsWith() > > > > My reasons for this are: > > - The spec says match which to my mind says equals() > > - It removes the need for special handling for root > > - It fixes bug 13040 > > > > However, changing this will break anything that assumes > that the matching is > > performed on a startsWith() basis. This is bad. Have we > ever received > > clarification from the spec team in this area? If not could > someone point me > > towards someone who may be able to offer some advice. > > > > As I see it there are three ways to deal with this: > > - ignore it - not an option I like > > - leave the code as is, closing bug 13040 as WONTFIX with > an explantion as to > > why > > - make the change > > > > Thoughts anyone? > > The rest of the algorithm will do the startsWith, right ? > This is why I said it was a shortcut: it will handle the simple case > where "/" is the parameter.
Fixing bug 13040 requires an additional patch that uses equals() for the whole algorithm. Hence the complications. This is what I was discussing above. > > Rémy > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
