I'll roll back, fix my editor, I just noticed that

Filip

-----Original Message-----
From: Remy Maucherat [mailto:[EMAIL PROTECTED]
Sent: Monday, January 12, 2004 12:16 AM
To: Tomcat Developers List
Subject: Re: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session
StandardManager.java


[EMAIL PROTECTED] wrote:
> fhanik      2004/01/11 21:21:48
>
>   Modified:    catalina/src/share/org/apache/catalina Manager.java
>                catalina/src/share/org/apache/catalina/core
>                         StandardContext.java
>                catalina/src/share/org/apache/catalina/session
>                         StandardManager.java
>   Log:
>   Refactoring parts of the code. In order for custom managers
(such as the clustering managers) to take advantage of the
background threads that are already implemented, it is better to
have the Manager interface to expose the backgroundProcess method.
That way the context can invoke any other manager in a similar way.
>   I opted for this way instead of using reflection. Yell if you
don't like it, and I will change it back.

-1.
You have to discuss this at least a little bit before making the
changes. It is unacceptable to make a change to the core interfaces without.

BTW, use a different editor, tweaks yours, or do tabs replacement (or
similar) in a separate commit: the diffs are unreadable.

Rémy


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to