>Could you explain a little more what these diffs accomplish? My
>understanding of the fix that went into revision 1.5.2.4 to
>fix the file upload problem was that doRead() returns an 'int' and was
>causing the byte >0xFF to be sign extended into the integer -1 which is the
EOF
>return value for doRead().
Commited by Dan or Keith ?)
>The byte array version of doRead() should only
>return -1 if
>there really isn't any more data. The actualy contents of the
>bytes read, because they aren't interpretted, don't matter at all.
The problem is related to encoding ?)
How did the data are then passed (and translated)
from byte[] to the servlet ?
>I don't see how the byte array returned is any different in the patched
>version then what it was before. Converting a byte into a
>char and then masking off all but the lowest 8 bits and then turning the
>results back into a byte looks like a no-op to me.
+1