I committed that fix a few months ago; I thought I
got both methods but must not have. I will investigate.
Keith
| -----Original Message-----
| From: kevin seguin [mailto:[EMAIL PROTECTED]]
| Sent: Thursday, May 17, 2001 7:22 AM
| To: [EMAIL PROTECTED]
| Cc: [EMAIL PROTECTED]
| Subject: Re: Servlet Upload Data Corruption
|
|
| i didn't see any comments in commit messages that mentioned the problem
| you are speaking of. can you find that comment again and send it?
| thanks.
|
| DAK wrote:
| >
| > Here's my first submission! It pertains to Tomcat-3.2.1 and looks to be
| > the same in 3.2.2.b4
| >
| > I have some client code that sends a jar file to the servlet. The jar
| > file was getting corrupted. After much digging, I found a CVS commit to
| > Ajp13ConnectorRequest.java that mentioned a problem like this with the
| > doRead() method. It turns out the the same applies to the doRead(byte[],
| > int, int) method. The same problem exists in the Ajp12ConnectionHandler
| > for that byte array read. Single byte reads for both protocols work just
| > fine. I'm including the diffs for these classes to show what I'm talking
| > about. I may be called a developer now, but I'm certainly not a
| > commiter, so what is the procedure for getting this fix validated by
| > somebody else and put into the codebase?
| >
| > Index: Ajp13ConnectorRequest.java
| > ===================================================================
| > RCS file:
| >
| /home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/service
| /connector/Attic/Ajp13ConnectorRequest.java,v
| > retrieving revision 1.5.2.7
| > diff -r1.5.2.7 Ajp13ConnectorRequest.java
| > 274c274,277
| > < System.arraycopy(bodyBuff, pos, b, off, c);
| > ---
| > > //System.arraycopy(bodyBuff, pos, b, off, c);
| > > for (int i=pos, j=off, d=c; d > 0; i++, j++, d--) {
| > > b[j] = (byte)(((char)bodyBuff[i])&0xff);
| > > }
