Yes you were right to keep passing paste_stack in, I just noticed we could
change that separately :-).
Yes I think we could do the same with buffer-limit now it is global too.
I think let's not limit the length or charset of names for now, if someone sets
it to something silly it'll be a display issue only and their own fault anyway.
Did you see my comments about -s and -u?
Cheers
-------- Original message --------
From: J Raynor <jxray...@gmail.com>
Date: 24/04/2014 19:05 (GMT+00:00)
To: Nicholas Marriott <nicholas.marri...@gmail.com>
Cc: tmux-users@lists.sourceforge.net
Subject: Re: patch for named buffers
I kept passing in global_buffers since that's what the existing code
did, and I thought there might be a reason (planned future
functionality?), so I kept it. But it makes sense to not pass it in
if you don't expect other paste_stores. But why not do the same with
buffer-limit? paste_add can look it up instead of having every call
to paste_set look it up first and pass it in.
I thought you might object to having non-printable characters or long
buffer names because it might mess up the display in list-buffer and
choose-buffer. But I'll remove both restrictions if that's not a
valid concern.
> I renamed the compare funcs and make some other minor tweaks but didn't
> change the sticky/unsticky bits.
>
> Why do you limit the buffer names to 16 characters? 16 characters is too
> short, but why limit them at all?
>
> Also not certain about limiting them to printables, seems like that will
> stop people using UTF-8 in buffer names.
>
>
> Index: cmd-capture-pane.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/tmux/cmd-capture-pane.c,v
> retrieving revision 1.26
> diff -u -p -r1.26 cmd-capture-pane.c
> --- cmd-capture-pane.c 24 Apr 2014 09:14:43 -0000 1.26
> +++ cmd-capture-pane.c 24 Apr 2014 09:44:42 -0000
> @@ -38,7 +38,7 @@ char *cmd_capture_pane_history(struct a
> const struct cmd_entry cmd_capture_pane_entry = {
> "capture-pane", "capturep",
> "ab:CeE:JpPqS:t:", 0, 0,
> - "[-aCeJpPq] [-b buffer-index] [-E end-line] [-S start-line]"
> + "[-aCeJpPq] " CMD_BUFFER_USAGE " [-E end-line] [-S start-line]"
> CMD_TARGET_PANE_USAGE,
> 0,
> NULL,
> @@ -165,7 +165,7 @@ cmd_capture_pane_exec(struct cmd *self,
> struct client *c;
> struct window_pane *wp;
> char *buf, *cause;
> - int buffer;
> + const char *bufname;
> u_int limit;------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users
