Hi Nicholas,
I tried your patch and I'm sorry to say that I don't like it :-(
mainly because focus is not remembered across large nested blocks.
For example, consider the following scenario of what I expect:
1 2 3 4 5
@@@@@@@@@ +---@@@@@ +---+---+ @@@@@---+ +---+---+
@ @ | @ @ | | Y | @ @ Y | | | Y |
@ X @ | X @ Y @ | X @@@@@ @ X @---+ | X @@@@@
@ @ | @ @ | @ Z @ @ @ Z | | @ Z @
@@@@@@@@@ +---@@@@@ +---@@@@@ @@@@@---+ +---@@@@@
6 7 8
+---+-------+ @@@@@-------+ +---+-------+
| | Y | @ @ Y | | | Y |
| X +---@@@@@ @ X @---+---+ | X +---@@@@@
| | Z @ W @ @ @ Z | W | | | Z @ W @
+---+---@@@@@ @@@@@---+---+ +---+---@@@@@
1. We run `tmux new-window` to create pane X.
2. We run `tmux split-window -h` to create and focus pane Y.
3. We run `tmux split-window` to create and focus pane Z.
4. We run `tmux select-pane -L` to focus pane X.
5. We run `tmux select-pane -R` to focus pane Z, thanks to remembrance.
6. We run `tmux split-window -h` to create and focus pane W.
7. We run `tmux select-pane -R` to focus pane X.
8. We run `tmux select-pane -R` to focus pane W, thanks to remembrance.
Here, what I mean by "large nested block" is pane X and block Y,Z,W.
I expect block Y,Z,W to remember its last focused pane, wherever that
may be, when focus moves outside that block to pane X. Similarly,
when focus moves from pane X into block Y,Z,W, I expect the last
focused pane in that block to regain focus.
These expectations are not satisfied by the most recent
"tmux-pane-select.diff" patch in this discussion thread, so I must
therefore disapprove of it.
Thanks for your consideration.
On Fri, Apr 18, 2014 at 4:42 PM, Nicholas Marriott
<nicholas.marri...@gmail.com> wrote:
>
> Can you try my latest patch and see if it still works acceptably for you?
>
>
>
> On Fri, Apr 18, 2014 at 04:34:22PM -0700, Suraj Kurapati wrote:
>> On Thu, Apr 17, 2014 at 1:07 PM, Thomas Adam <tho...@xteddy.org> wrote:
>> > if this behaviour needs reverting, and/or enough people complain,
>> > we'll consider doing so?
>>
>> I, for one, have no complaints about the current behaviour because I
>> was among[1] those[2] who requested[3] the current behavior in the
>> first place. Thus I plead you to please keep the current behaviour!
>>
>> Thanks for your consideration.
>>
>> [1]: http://sunaku.github.io/tmux-refocus-patch.html
>> [2]: http://sourceforge.net/p/tmux/tickets/97/
>> [3]: http://sourceforge.net/p/tmux/mailman/message/31746584/
>>
>> ------------------------------------------------------------------------------
>> Learn Graph Databases - Download FREE O'Reilly Book
>> "Graph Databases" is the definitive new guide to graph databases and their
>> applications. Written by three acclaimed leaders in the field,
>> this first edition is now available. Download your free book today!
>> http://p.sf.net/sfu/NeoTech
>> _______________________________________________
>> tmux-users mailing list
>> tmux-users@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/tmux-users
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users
