Hi On Mon, Mar 14, 2011 at 01:21:04AM +0000, Sean Estabrooks wrote: > Okay, third patch attempt attached for review. Ended up tossing out > the state machine changes since it was difficult to accommodate > the reset sequence which only has a parameter and no value string. > > I did try using NULL for the empty colour strings in the screen > and tty structs, but it was a bit awkward, so this patch is the > same as before in that regard.
This is fine. > > > > > Also I suspect we only want to enable this if the terminal matches > > xterm* or it is very likely to cause problems. Maybe do a check like > > tty_set_title? > > > > Okay, it will only be enabled when the underlying terminal is > recognized (a la tty_set_title). This isn't perfect but is in > line with the existing code. It's not 100% clear that any > restriction is needed since neither sequence would be sent to > the underlying terminal unless an application used them first, > but better safe than sorry. Does rxvt support these sequences? I don't think screen does. Probably best only to check for xterm. > > The current patch has been tested with xterm and a custom version > of Putty. As mentioned in the patch header, the reset sequence > only works on xterm when you set a default cursor colour, (by > command line "xterm -cr blue" for example). It is pretty stupid that xterm doesn't have a proper reset, this is probably the best we can do. gnome-terminal doesn't appear to support 112 but not much we can do about that. > > Let me know if the patch needs any further work. > > Cheers, > Sean > > ------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
