> Date: Sun, 13 Mar 2011 21:28:54 +0000
> From: nicholas.marri...@gmail.com
>
> This looks good.
>
> You will have to use \033]112\007 to reset the cursor colour to default
> for panes where it hasn't been set. Personally I would use NULL for this
> rather than an empty string but it's not too important.
>
> Also please change color to colour or it'll make it harder to grep.
>
Hi Nicholas,
Okay, third patch attempt attached for review. Ended up tossing out
the state machine changes since it was difficult to accommodate
the reset sequence which only has a parameter and no value string.
I did try using NULL for the empty colour strings in the screen
and tty structs, but it was a bit awkward, so this patch is the
same as before in that regard.
>
> Also I suspect we only want to enable this if the terminal matches
> xterm* or it is very likely to cause problems. Maybe do a check like
> tty_set_title?
>
Okay, it will only be enabled when the underlying terminal is
recognized (a la tty_set_title). This isn't perfect but is in
line with the existing code. It's not 100% clear that any
restriction is needed since neither sequence would be sent to
the underlying terminal unless an application used them first,
but better safe than sorry.
The current patch has been tested with xterm and a custom version
of Putty. As mentioned in the patch header, the reset sequence
only works on xterm when you set a default cursor colour, (by
command line "xterm -cr blue" for example).
Let me know if the patch needs any further work.
Cheers,
Sean
color3.patch
Description: Binary data
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d
_______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
