On Thu, 9 Mar 2023 at 06:50, joshua stein <j...@jcs.org> wrote:
> On Thu, 09 Mar 2023 at 06:41:50 +1100, Darren Tucker wrote:
> > This seems to be one too many parens? ie
> > if (negate = (attrib[0] == '!'))
>
> clang warns if there's not the extra set of parens in case it's an
> accidental = instead of ==.
ok dtucker for this one.
"no objection" to the sshpty.c one.
--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
