On Thu, 09 Mar 2023 at 06:41:50 +1100, Darren Tucker wrote: > > + if ((negate = (attrib[0] == '!'))) > > This seems to be one too many parens? ie > if (negate = (attrib[0] == '!'))
clang warns if there's not the extra set of parens in case it's an
accidental = instead of ==.
/usr/src/usr.bin/ssh/ssh/../readconf.c:605:14: warning: using the result of an
assignment as a condition without parentheses [-Wparentheses]
if (negate = (attrib[0] == '!'))
