On Thu, Dec 22, 2022 at 06:21:08PM +0100, Claudio Jeker wrote:
> On Thu, Dec 22, 2022 at 05:08:15PM +0000, Jason McIntyre wrote:
> > On Thu, Dec 22, 2022 at 07:32:18AM +0000, Jason McIntyre wrote:
> > > 
> > > next step is to examine Xr. will get round to that when i can.
> > > 
> > 
> > so i looked at where we are using netstat. a lot of the references still
> > make sense. diff below is for ones i think we can change. claudio kindly
> > help me sift through some of the less clear ones (specifically where we
> > have an Xr to netstat(1) in SEE ALSO but do not discuss it in any way
> > within the manual).
> > 
> > here's the diff.
> > 
> 
> A few comments below.
> 
> > Index: share/man/man4/ipcomp.4
> > ===================================================================
> > RCS file: /cvs/src/share/man/man4/ipcomp.4,v
> > retrieving revision 1.16
> > diff -u -p -r1.16 ipcomp.4
> > --- share/man/man4/ipcomp.4 12 Jan 2018 04:36:44 -0000      1.16
> > +++ share/man/man4/ipcomp.4 22 Dec 2022 17:04:39 -0000
> > @@ -105,9 +105,9 @@ can be used to obtain some statistics ab
> >  .Fl p
> >  flag.
> >  Just like for IPsec, using the
> > -.Fl r
> > -flag,
> > -.Xr netstat 1
> > +.Xr route 8
> > +.Cm show
> > +command
> >  displays information about IPComp flows.
> 
> That's a lie. Neither netstat nor route show IPsec flows. This was moved
> to ipsecctl(8). At least I was not able to display the flows with netstat
> or route.
> 

ah. so i tried ipcomp but thought it was maybe just not compiled in.

so what about the note above it:

    DIAGNOSTICS
         netstat(1) can be used to obtain some statistics about
         IPComp usage, using the -p flag.

i can;t get netstat -p to do anything useful. should this whole text go,
or just the -r text?

> >  .Sh SEE ALSO
> >  .Xr enc 4 ,
> > Index: share/man/man4/ipsec.4
> > ===================================================================
> > RCS file: /cvs/src/share/man/man4/ipsec.4,v
> > retrieving revision 1.88
> > diff -u -p -r1.88 ipsec.4
> > --- share/man/man4/ipsec.4  31 Mar 2022 17:27:21 -0000      1.88
> > +++ share/man/man4/ipsec.4  22 Dec 2022 17:04:39 -0000
> > @@ -360,10 +360,9 @@ can be used to obtain some statistics ab
> >  .Fl p
> >  flag.
> >  Using the
> > -.Fl r
> > -flag,
> > -.Xr netstat 1
> > -displays information about IPsec flows.
> > +.Xr route 8
> > +.Cm show
> > +command displays information about IPsec flows.
> 
> See above.
> 

ditto

> >  .Pp
> >  .Xr vmstat 8
> >  displays information about memory use by IPsec with the
> > Index: share/man/man8/afterboot.8
> > ===================================================================
> > RCS file: /cvs/src/share/man/man8/afterboot.8,v
> > retrieving revision 1.171
> > diff -u -p -r1.171 afterboot.8
> > --- share/man/man8/afterboot.8      13 Apr 2022 18:00:34 -0000      1.171
> > +++ share/man/man8/afterboot.8      22 Dec 2022 17:04:39 -0000
> > @@ -184,7 +184,8 @@ See
> >  for instructions on configuring interfaces with DHCP.
> >  .Pp
> >  Routing tables can be viewed by issuing a
> > -.Ic netstat -rn
> > +.Xr route 8
> > +.Cm show
> 
> Should we add -n here as well so people don't end up waiting for DNS
> lookups? I would love if someone made -n the default and add a -N flag
> instead. Reverse DNS lookups are just not helpful in routing table output.
> 

yep, good spot. i'll adjust this.

jmc

Reply via email to