On Wed, Dec 21, 2022 at 05:15:35PM -0500, Paul Tagliamonte wrote:
> Good news, I've got my MUA sorted. Hopefully this fixes the issues with
> the CVS diffs in my reply body.
> 
> On Wed, Dec 21, 2022 at 10:09:24PM +0000, Jason McIntyre wrote:
> > i like the choice of "display" over "print out".
> > i don;t like the "related metadata" bit though.
> > 
> > what about just
> > 
> >     Display the routing table.
> 
> done.
> 
> > you should start new sentences on new lines.
> 
> understood, done.
> 
> > i would not remove the Xr. i think if we go ahead with this, we can make
> > a separate commit where we point people to route(8) rather than
> > netstart(8), but i suspect many pages will both want references to both.
> 
> makes sense, done.
> 
> > except for that, diff seems fine.
> 
> updated patch for review attached; thank you for your (very fast!) review.
> On the off-chance I've dorked it up, i've attached it, but I think we
> should be sorted.
> 
>   paultag
> 
> -- 
> :wq
> 

hi.

so i committed your diff, with some tweaks:

- respaced the indent on the entire command list (width Fl -> Ds).
  it was too large.

- you missed an ".El" in your diff. that turned out to be quite
  fortunate, because trying to work out where it was made me find a bug
  associated with how we added the "nameserver" command. the result
  being that the text no longer squashes after "nameserver".

- i slightly reworded the text, since just plonking in "The flags column" seemed
  a bit isolated.

- i forgot it in my commit message, but i shortened the desciption for
  RTF_GATEWAY to keep all entries on a single line.

so what i actually committed to route(8) is shown below. i didn;t
include netstat(1) since i took that as-is.

next step is to examine Xr. will get round to that when i can.

thanks for the diff.
jmc

Index: sbin/route/route.8
===================================================================
RCS file: /cvs/src/sbin/route/route.8,v
retrieving revision 1.106
diff -u -p -r1.106 route.8
--- sbin/route/route.8  19 Nov 2022 19:23:37 -0000      1.106
+++ sbin/route/route.8  22 Dec 2022 07:17:26 -0000
@@ -92,7 +92,7 @@ instead of a real routing socket to test
 The
 .Nm
 utility provides the following simple commands:
-.Bl -tag -width Fl
+.Bl -tag -width Ds
 .It Xo
 .Nm route
 .Op Fl T Ar rtable
@@ -159,9 +159,6 @@ are shown.
 If a routing table is supplied with
 .Fl T ,
 only changes in that routing table will be displayed.
-.El
-.Pp
-.Bl -tag -width Fl -compact
 .It Xo
 .Ic route
 .Op Fl dtv
@@ -185,7 +182,6 @@ If no
 .Ar address
 argument is given, a request to remove the nameservers previously entered for
 the given interface is sent.
-.Pp
 .It Xo
 .Nm route
 .Op Fl nv
@@ -197,10 +193,7 @@ the given interface is sent.
 .Op Fl label Ar label
 .Op Fl priority Ar priority
 .Xc
-Print out the routing table, in a fashion similar to "netstat -r".
-The output is documented in more detail towards the end of the
-.Xr netstat 1
-manual.
+Display the routing table.
 .Pp
 If
 .Fl gateway
@@ -224,6 +217,34 @@ or
 .Cm bgp .
 If the priority is negative, then routes that do not match the numeric
 priority are shown.
+.Pp
+Within the output of
+.Cm show ,
+the "Flags" column indicates what flags are set on the route.
+The mapping between letters and flags is:
+.Bl -column "1" "RTF_BLACKHOLE" "Protocol specific routing flag #1."
+.It 1 Ta Dv RTF_PROTO1 Ta "Protocol specific routing flag #1."
+.It 2 Ta Dv RTF_PROTO2 Ta "Protocol specific routing flag #2."
+.It 3 Ta Dv RTF_PROTO3 Ta "Protocol specific routing flag #3."
+.It B Ta Dv RTF_BLACKHOLE Ta "Just discard pkts (during updates)."
+.It b Ta Dv RTF_BROADCAST Ta "Correspond to a local broadcast address."
+.It C Ta Dv RTF_CLONING Ta "Generate new routes on use."
+.It c Ta Dv RTF_CLONED Ta "Cloned routes (generated from RTF_CLONING)."
+.It D Ta Dv RTF_DYNAMIC Ta "Created dynamically (by redirect)."
+.It G Ta Dv RTF_GATEWAY Ta "Dest requires forwarding by intermediary."
+.It H Ta Dv RTF_HOST Ta "Host entry (net otherwise)."
+.It h Ta Dv RTF_CACHED Ta "Referenced by gateway route."
+.It L Ta Dv RTF_LLINFO Ta "Valid protocol to link address translation."
+.It l Ta Dv RTF_LOCAL Ta "Correspond to a local address."
+.It M Ta Dv RTF_MODIFIED Ta "Modified dynamically (by redirect)."
+.It m Ta Dv RTF_MULTICAST Ta "Correspond to a multicast address."
+.It n Ta Dv RTF_CONNECTED Ta "Interface route."
+.It P Ta Dv RTF_MPATH Ta "Multipath route."
+.It R Ta Dv RTF_REJECT Ta "Host or net unreachable."
+.It S Ta Dv RTF_STATIC Ta "Manually added."
+.It T Ta Dv RTF_MPLS Ta "MPLS route."
+.It U Ta Dv RTF_UP Ta "Route usable."
+.El
 .El
 .Pp
 .Bl -tag -width Fl -compact

Reply via email to