On Fri, May 27, 2016 at 08:41:33PM +0200, Marcus Glocker wrote: > Hello Patrick, > > On Thu, May 26, 2016 at 04:09:26PM -0700, patrick keshishian wrote: > > > Hi, > > > > Included is my initial effort to port the dual-licensed driver > > for Fushicai Audio-Video Grabber (vendor 0x1b71 product 0x3002). > > > > As I mentioned in previous email it is "mostly working". I have > > tested it on amd64 and macppc. The macppc audio issue mentioned > > got resolved thanks to a hint from Alexandre Ratchov; I needed > > some education on how to use sndiod :-) Thanks Alex. > > > > I realize not many of these devices are out in the hands of > > people who could test this code, but there are some obvious > > bits (especially in the audio ops) that I am "winging", partly > > because, the audio interface required them. > > > > There is .h and two .c files; as mentioned, I kept the original > > driver source bits and what I borrowed from uvideo.c separate. > > If they must be combine into one .c file, I leave that part to > > Marcus Glocker and company. > > > > My main testing tool has been video(1). I had to modify it for > > two reasons: 1. To test the mmap() interface and 2. because > > to determine format description video(1) does a strcmp() rather > > than use the pixelformat member of the v4l2_fmtdesc struct. > > Patch at the very end. Maybe upstream might be interested in > > the mmap change? > > > > Cheers, > > --patrick > > Ok, lets work together to get this driver imported. > > First thing to sort out are the Copyrights: > > - Please change the uvideo Copyright to your own and add a sentence like > "Based on the uvideo driver". You can find some good examples e.g. > here: cd /usr/src/sys/dev/usb ; grep -i based *.c > > - Can you please get in touch with the original authors of the other > code and ask them if they could fix their Copyright to make it valid? > Theo did also point out about a valid Copyright format: > 1. Copyright ... > 2. [rights granted] > 3. [legacy disclaimer, not really required] > 4. [extra text] > 5. [source] > Important is that the Copyright must be followed by the rights.
Thanks. I'll get on this. --patrick > In the meantime I give the driver spin. Maybe I can find such a device > somewhere at one point. >
