On Sat, Sep 26, 2015 at 09:58:59PM +0200, Stefan Sperling wrote: > On Sat, Sep 26, 2015 at 03:51:25PM -0400, Michael McConville wrote: > > Stefan Sperling wrote: > > > On Sat, Sep 26, 2015 at 03:29:07PM -0400, Michael McConville wrote: > > > > I see some preproc conditions in usr.sbin/snmpctl/snmpclient.c. I > > > > only bothered to check the first two. Are you sure they still > > > > compile in all circumstances? If I understand correctly, compiling > > > > without warning only implies safety if the preproc isn't > > > > conditionally including code. > > > > > > FWIW, it compiles with make CPPFLAGS="-DDEBUG" and with > > > make CPPFLAGS="-DDEBUG=2". > > > > A quick grep shows '#ifdef RTF_MPATH' in usr.sbin/snmpd/kroute.c and > > Yes, that one looks safe. It's using things also used outside the ifdef.
RTF_MPATH was added in some places to increase portability since this is mostly an OpenBSD-ism. Not sure if we still care... > > > '#ifdef notyet' in usr.sbin/snmpd/mib.c. Less variety than I expected, > > and the notyet block is unlikely to be functional anyway. > > notyet was left for the future -> don't care > -- :wq Claudio
