Stefan Sperling wrote:
> On Sat, Sep 26, 2015 at 03:29:07PM -0400, Michael McConville wrote:
> > I see some preproc conditions in usr.sbin/snmpctl/snmpclient.c. I
> > only bothered to check the first two. Are you sure they still
> > compile in all circumstances? If I understand correctly, compiling
> > without warning only implies safety if the preproc isn't
> > conditionally including code.
>
> FWIW, it compiles with make CPPFLAGS="-DDEBUG" and with
> make CPPFLAGS="-DDEBUG=2".
A quick grep shows '#ifdef RTF_MPATH' in usr.sbin/snmpd/kroute.c and
'#ifdef notyet' in usr.sbin/snmpd/mib.c. Less variety than I expected,
and the notyet block is unlikely to be functional anyway.
There's a tool for testing this more rigorously, but I remember it being
hard to use:
http://include-what-you-use.org/
