There's a topic on peace-keeping in a large project. There are two types of feedback:
- "this change makes the code simpler and twice as fast" (it's objectively better) - "I like colorful terminals" (my personal opinion) Objecting to a diff like this causes friction. I like Rin, and I don't want him to get the habit that his changes are unwelcome. So I try to avoid unnecessary complaints on things that are personal taste. Bikeshed type discussions in general are very draining, and topics that are accessible to a wide audience like color in shell commands are prone to them. When your complaint is: - The default 16 color scheme includes colors that aren't legible to my colorblind self, and excessive use of color by defaults hurts terminal legibility for me. It's objective feedback, and I hope we don't default to a colorful terminal without addressing it (since doing so is a lot harder, I don't expect this to happen).
